[wp-trac] [WordPress Trac] #48569: Twenty Twenty: Theme-specific editor styles being improperly enqueued

WordPress Trac noreply at wordpress.org
Tue Nov 12 17:24:38 UTC 2019


#48569: Twenty Twenty: Theme-specific editor styles being improperly enqueued
---------------------------+-----------------------------
 Reporter:  markjaquith    |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  5.3.1
Component:  Bundled Theme  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:  administration
---------------------------+-----------------------------

Comment (by markjaquith):

 Replying to [comment:3 joyously]:
 > It's not improper. It's the theme's choice of how to do it, not the
 editor's choice.
 > The `add_editor_style()` choice is not always compatible with the
 styles.

 I'm not sure I understand.

 Yes, Twenty Twenty has chosen to force its styles into the editor, even
 for non-public post types that try to opt out of editor styles by using
 APIs for doing so that worked for previous core-bundled themes. I'm saying
 that's a bad choice, because Twenty Twenty is making the invalid
 assumption that all instances of the block editor are intended for editing
 content that will display in the theme, and should thus look like the
 theme.

 If `add_editor_style()` is not able to accomplish its job of crafting
 front-page-matching editor styles for the block editor, then this is a
 much more serious problem than Twenty Twenty using the wrong API.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48569#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list