[wp-trac] [WordPress Trac] #48570: incorrect return type for check_parent_theme_filter

WordPress Trac noreply at wordpress.org
Tue Nov 12 17:18:06 UTC 2019


#48570: incorrect return type for check_parent_theme_filter
--------------------------+-----------------------------
 Reporter:  diddledan     |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  General       |    Version:  trunk
 Severity:  normal        |   Keywords:  has-patch
  Focuses:  docs          |
--------------------------+-----------------------------
 In `wp-admin/includes/class-theme-upgrader.php` the return type for method
 `check_parent_theme_filter` is incorrectly set to `type`. Presumably this
 is a result of an IDE's docblock template not being filled-out fully when
 documenting the function leaving the placeholder `type`.

 The attached patch sets the return type to `bool` to match the type of
 `$install_result`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48570>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list