[wp-trac] [WordPress Trac] #48207: Implement new Comment Date Functions

WordPress Trac noreply at wordpress.org
Fri Nov 8 11:42:21 UTC 2019


#48207: Implement new Comment Date Functions
-------------------------------------------+------------------------------
 Reporter:  dshanske                       |       Owner:  (none)
     Type:  defect (bug)                   |      Status:  new
 Priority:  normal                         |   Milestone:  Awaiting Review
Component:  Date/Time                      |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  needs-unit-tests dev-feedback  |     Focuses:
-------------------------------------------+------------------------------

Comment (by dshanske):

 @Rarst I tried to make it as close a copy as possible, figuring that once
 we ironed out if this is the approach, we could duplicate the same unit
 tests you did for the post versions of these functions.

 As for adding to the API, I can understand the process issue of having it
 as a separate ticket, however, without it, you would have more duplicative
 code. And as mentioned, it brings get_comment_time in line with
 get_post_time in terms of behavior. It seems unnecessary to introduce a
 new function for this.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48207#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list