[wp-trac] [WordPress Trac] #48535: Incompatibility with PHP 7.3.11

[WordPress Trac]

#48535: Incompatibility with PHP 7.3.11
--------------------------+-----------------------------
 Reporter:  szymon.nosal  |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  General       |    Version:  5.2.4
 Severity:  critical      |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 I set up totally new env with WordPress 5.2.4 on PHP 7.3.11 and I found a
 couple of problems. In the main opinion, these problems are critical.

 1. Ajax response always contains '0' on the end of the response - default
 code wp_die('0') is always execute. Below is an example response for
 install the new plugin (chosen randomly)

 {{{
 {"success":true,"data":{"install":"plugin","slug":"health-
 check","pluginName":"Health Check &
 Troubleshooting","activateUrl":"http:\/\/woocommerce.local\/wp-
 admin\/plugins.php?_wpnonce=6a458d9d59&action=activate&plugin=health-check
 \/health-check.php"}}0
 }}}

 And message displayed in the admin panel informs that installation failed,
 but module is installed correctly.

 2. After clicking on the Activate button, after installation module from
 the zip file, redirect to page like

 {{{
 <url>/wp-admin/plugins.php?action=activate&plugin=wp-serverinfo%2Fwp-
 serverinfo.php&_wpnonce=2740398a2b
 }}}

 but on the page is error message: **The link you followed has expired.**
 but module is activated correctly.

 3. The next one is related to admin wizard setup for WooCommerce plugin,
 but in my opinion, this is problem with core code, because setup form is
 loaded correctly, but code is not dying, and try to load this as a normal
 plugin. I'm attaching a screenshot with this.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48535>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform