[wp-trac] [WordPress Trac] #47708: 5.3 about page

[WordPress Trac]

#47708: 5.3 about page
-------------------------------------------------+-------------------------
 Reporter:  karmatosed                           |       Owner:  (none)
     Type:  task (blessed)                       |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.3
Component:  Help/About                           |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  i18n-change needs-screenshots has-   |     Focuses:
  patch                                          |  accessibility
-------------------------------------------------+-------------------------
Changes (by ryelle):

 * keywords:  i18n-change needs-screenshots needs-patch => i18n-change
     needs-screenshots has-patch


Comment:

 Replying to [comment:114 bwmarkle]:
 > To prevent other plugins' notices from showing on the about page, should
 those styles be amended to hide notices from `.about__container` too?

 That should be done with the latest patches, unfortunately
 [attachment:"47708.13.diff"] didn't make it into RC but if you try
 [attachment:"47708.15.diff"] it should hide your notice.

 Replying to [comment:112 luminuu]:
 > I'd like to add that in the SVG in the upper left corner, the circle
 around 5.3 is also an oval in Firefox 70.0.1, like seen in the screenshot
 of @davidbaumwald. Tested on macOS 10.14.6.

 While the blurriness isn't intentional, this is meant to be an oval - that
 screenshot is the correct appearance.

 Replying to [comment:111 afercia]:
 > This would be the first time CSS variables are introduced in core […]
 since each color needs to provide a fallback for old browsers by using
 standard hex values, I'm not sure why the about page is using CSS
 variables in the first place.

 The variables are now scoped to the `.about__container`, so they will only
 be used on the about page, essentially making them "private" variables. I
 don't think this ticket is the place to make build tool changes, so I
 didn't bring this up, but I will be proposing adding
 [https://github.com/postcss/postcss-custom-properties a postcss processor]
 for generating these hex fallbacks.

 The point of this about page rewrite is to make it easier for future folks
 to tweak the design of the page. Part of that will mean updating the
 colors, so we're using variables here to make that easier. I have some
 docs in progress that explains
 [https://gist.github.com/ryelle/91ef6cd84a197b6af880dc055be21cc9 how to
 work with this page] and how the colors are used. The goal here is that
 future releases will be faster to design and code, because there will be a
 defined system to work with.

 I would also +100000 any ticket to get a stylelint checker into core – but
 [attachment:"47708.15.diff"] fixes that CSS issue & the attr issue.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47708#comment:115>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform