[wp-trac] [WordPress Trac] #47708: 5.3 about page

[WordPress Trac]

#47708: 5.3 about page
-------------------------------------------------+-------------------------
 Reporter:  karmatosed                           |       Owner:  (none)
     Type:  task (blessed)                       |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.3
Component:  Help/About                           |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  i18n-change needs-screenshots        |     Focuses:
  needs-patch                                    |  accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):

 * keywords:  i18n-change has-patch needs-screenshots => i18n-change needs-
     screenshots needs-patch


Comment:

 [attachment:"47708.14.diff"] solves the contrast issues, thank you!

 Noticed a couple things that need to be addressed:
 - proper escaping: `alt="<?php _e( 'Code is Poetry' ); ?>"` should use
 `esc_attr_e()`
 - coding standards: all the named color values e.g. `background: white;`
 need to use the corresponding hex value instead, as per the CSS coding
 standards

 Reference:

 https://make.wordpress.org/core/handbook/best-practices/coding-
 standards/css/#properties
 > **Use hex code for colors, or rgba()** if opacity is needed. Avoid RGB
 format and uppercase, and shorten values when possible: #fff instead of
 #FFFFFF.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47708#comment:113>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform