[wp-trac] [WordPress Trac] #48526: TwentyNineteen: Update margins in editor styles to address upcoming block editor margin changes

WordPress Trac noreply at wordpress.org
Thu Nov 7 09:31:09 UTC 2019


#48526: TwentyNineteen: Update margins in editor styles to address upcoming block
editor margin changes
--------------------------+-----------------------------
 Reporter:  Joen          |      Owner:  (none)
     Type:  defect (bug)  |     Status:  assigned
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Themes        |    Version:
 Severity:  normal        |   Keywords:  has-patch
  Focuses:                |
--------------------------+-----------------------------
 In https://github.com/WordPress/gutenberg/pull/17877, the left and right
 margins of all blocks are refactored. This change will make it easier for
 block and theme developers to create more complex designs, because those
 margins are now effectively gone in most cases, meaning there's nothing to
 compensate for.

 TwentyNineteen compensates for those margins that have now been removed.
 In doing so the layout now looks broken.

 This patch updates the TwentyNineteen editor styles to address that.

 Please test by running the latest master of the Gutenberg plugin,
 WordPress version doesn't matter, and TwentyNineteen with this patch
 applied. Test images, galleries, cover and other blocks that can receive
 full-wide alignment, and verify there is no horizontal scrollbar in the
 editor. Then test with a full-wide group block, with and without
 background, verify there's no horizontal scrollbar. Then test a fullwide
 image inside a fullwide group block and verify there are no horizontal
 scrollbars.

 Finally verify that the little gray "tick" that sits above headlines, is
 also correctly aligned above the Title.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48526>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list