[wp-trac] [WordPress Trac] #47708: 5.3 about page
WordPress Trac
noreply at wordpress.org
Thu Nov 7 08:05:10 UTC 2019
#47708: 5.3 about page
-------------------------------------------------+-------------------------
Reporter: karmatosed | Owner: (none)
Type: task (blessed) | Status: reviewing
Priority: normal | Milestone: 5.3
Component: Help/About | Version:
Severity: normal | Resolution:
Keywords: i18n-change has-patch needs- | Focuses:
screenshots | accessibility
-------------------------------------------------+-------------------------
Comment (by afercia):
Replying to [comment:106 johnbillion]:
> I noticed that CSS variables are being used on the About page. What does
the page look like in IE11?
I'll repeat my previous consideration:
> maybe I'm missing something but I don't see any discussion on the
introduction of CSS variables. This would be the first time CSS variables
are introduced in core and I'd tend to think this kind of new
implementation should be at least discussed a bit, as it always happened
in the past.
I do think this kind of decisions shouldn't be made by one single team or
by one single person without a prior discussion on the technical direction
that should happen publicly in the proper places. After the discussion,
the decision is up to this project tech leads. I haven't seen this
happening in this specific case and I'm not sure this is the best process
to follow.
Moreover, since each color needs to provide a fallback for old browsers by
using standard `hex` values, I'm not sure why the about page is using CSS
variables in the first place. Seems to me they're used just for the sake
of using them and they actually don't add a great value. Instead, they add
a layer of unnecessary complexity.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47708#comment:111>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list