[wp-trac] [WordPress Trac] #19647: Use add_node() instead of add_menu() in core

[WordPress Trac]

#19647: Use add_node() instead of add_menu() in core
--------------------------------------------------+------------------------
 Reporter:  linuxologos                           |       Owner:  chriscct7
     Type:  enhancement                           |      Status:  reopened
 Priority:  low                                   |   Milestone:  5.4
Component:  Toolbar                               |     Version:  3.3
 Severity:  normal                                |  Resolution:
 Keywords:  has-patch needs-dev-note 2nd-opinion  |     Focuses:
--------------------------------------------------+------------------------
Changes (by johnbillion):

 * keywords:  has-patch needs-dev-note commit => has-patch needs-dev-note
     2nd-opinion
 * status:  closed => reopened
 * resolution:  fixed =>
 * milestone:  Future Release => 5.4


Comment:

 I'm not sure that this deprecated notice provides much value. Most plugins
 that add an admin toolbar menu are using the `add_menu()` method, as was
 core until this changeset.

 A search for `>add_menu(` in the plugin directory returns over 1,200
 results: https://wpdirectory.net/search/01DS0ZDS11A6JZEF4VH3SNVZAF

 I'd like to propose removing the deprecated notice for this method. It
 might have made sense eight years ago but it now seems like an unnecessary
 deprecation given its widespread usage.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/19647#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform