[wp-trac] [WordPress Trac] #47708: 5.3 about page

[WordPress Trac]

#47708: 5.3 about page
-----------------------------------+----------------------------
 Reporter:  karmatosed             |       Owner:  (none)
     Type:  task (blessed)         |      Status:  reviewing
 Priority:  normal                 |   Milestone:  5.3
Component:  Help/About             |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  i18n-change has-patch  |     Focuses:  accessibility
-----------------------------------+----------------------------
Changes (by ryelle):

 * keywords:  i18n-change needs-patch => i18n-change has-patch


Comment:

 [attachment:"47708.14.diff"] builds on 13.diff, and fixes the a11y issues
 above.

 Failing contrasts: strange, I tested the nav tabs with a colorpicker & it
 reads the color as `#68645a`, which passes… I've updated it to be
 `#716d64`, which has a ratio of 5. The inline links have also been
 updated.

 Text zoom & max height: The header box uses a default height of `90vh`,
 which is 90% of the viewport height - it's got a max-height so that it's
 not excessively large on tall screens.

 The credits page issues are a bit harder to solve, because that's a
 dynamically built list of "groups", and we want the separator sometimes
 but not always. Right now each group is in an `about__section`, and if the
 group type changes from one iteration to the next, we get the separator.
 So between the two translator groups, the type is `compact` then `list`,
 which is why the space is there. In the core contrib section, they're both
 `titles`, so no break, but the padding around both sections causes that
 visible extra space.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47708#comment:104>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform