[wp-trac] [WordPress Trac] #47388: Missing docs for filters in site health check

[WordPress Trac]

#47388: Missing docs for filters in site health check
-----------------------------------------+---------------------
 Reporter:  johnbillion                  |       Owner:  (none)
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  5.2.2
Component:  Administration               |     Version:  5.2
 Severity:  normal                       |  Resolution:
 Keywords:  servehappy has-patch commit  |     Focuses:
-----------------------------------------+---------------------
Changes (by desrosj):

 * keywords:  servehappy has-patch => servehappy has-patch commit


Comment:

 I agree that the `automatic_updates_is_vcs_checkout` filter should be
 replaced by the `WP_Upgrader::is_vcs_checkout()` as there is a lot of
 duplicated code, but there are some trade offs. The error message would
 become much less specific, for example. The checked directory and VCS
 directory would not be available currently without copying the logic over
 from the `WP_Upgrader` method and those are specifically mentioned in the
 messaging. The filter would also still need to be run to detect a change
 in value.

 Let's add the missing documentation here and open a new ticket to explore
 ways to remove the duplicated code.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47388#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform