[wp-trac] [WordPress Trac] #47070: Recovery Mode Exit button not visible in responsive view
WordPress Trac
noreply at wordpress.org
Wed May 29 07:49:26 UTC 2019
#47070: Recovery Mode Exit button not visible in responsive view
-------------------------------------------------+-------------------------
Reporter: afragen | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.2.2
Component: Bootstrap/Load | Version:
Severity: normal | Resolution:
Keywords: servehappy has-screenshots has- | Focuses: ui,
patch needs-refresh | administration
-------------------------------------------------+-------------------------
Comment (by afercia):
Quick screenshot (see below), to remind that plugins can add their menus
also on the right of the sidebar. Tested with the "View Admin As" plugin,
and I guess there are other plugins that do the same.
Placing the "Recovery Mode Exit" on the right on small screens would
likely break the admin bar layout.
WordPress never established strict rules for what plugins can add in the
admin menus so basically there's nothing to prevent plugins to do what
they want other than a few CSS rules that are very easy to override. The
related hooks can't be disabled because they're used by WordPress itself.
Relying on CSS doesn't seem a good idea as well.
I'd tend to think we should explore a new, reliable, way to conditionally
render menus in the admin bar.
Not sure if it's possible (just brainstorming and would appreciate any
feedback), what about to:
- introduce a new hook(s) exclusively meant to print out the Exit Recovery
Mode link and the other WordPress menus that should be available in
Recovery Mode
- when in Recovery Mode, disable all the hooks like `admin_bar_menu`
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47070#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list