[wp-trac] [WordPress Trac] #47411: Build tools, WPCS: disable line ending check
WordPress Trac
noreply at wordpress.org
Tue May 28 23:34:33 UTC 2019
#47411: Build tools, WPCS: disable line ending check
------------------------------+-------------------------------
Reporter: azaozz | Owner: azaozz
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 5.3
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: 2nd-opinion | Focuses: coding-standards
------------------------------+-------------------------------
Comment (by SergeyBiryukov):
Replying to [comment:6 azaozz]:
> I know, I've taken it upon myself to still (try to) develop on Windows
when pretty much "everybody" is on Mac or Linux. This is exactly to be
able to spot and fix this kind of issues (and of course to be able to
easily test in the Windows browsers).
FWIW, Windows is my main platform too.
I've noticed that `phpcs` flags `\r\n` line endings as an issue, but it
didn't seem like a big deal for me, as I generally run `phpcbf` on the
files I'm going to commit, and it fixes line endings in the process.
So I don't have a strong preference here.
> BTW there are some unit tests that fail because `\n` line endings are
hard-coded in the source, see #46798. Going to fix that next :)
Related: #31432
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47411#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list