[wp-trac] [WordPress Trac] #46798: PHPUnit warnings
WordPress Trac
noreply at wordpress.org
Tue May 28 23:21:14 UTC 2019
#46798: PHPUnit warnings
------------------------------+---------------------
Reporter: azaozz | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.3
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: 2nd-opinion | Focuses:
------------------------------+---------------------
Changes (by azaozz):
* keywords: => 2nd-opinion
* milestone: Future Release => 5.3
Comment:
Wondering how to best fix the above line endings problems. Can probably
ass a basic normalization as in 46798.diff, but seems a bit... fragile?
The other option is to do `assertContains()` as in all other HTML output
testing. All errors are in `phpunit/tests/dependencies/scripts.php` and
are caused by comparing with `wp_scripts_print_translations_output`. It
tests translation scripts outputted with `printf()`. Seems we can test
just one line there, not the whole script.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46798#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list