[wp-trac] [WordPress Trac] #24730: Introduce a timezone-retrieval method

[WordPress Trac]

#24730: Introduce a timezone-retrieval method
--------------------------------------+-----------------------------
 Reporter:  rmccue                    |       Owner:  SergeyBiryukov
     Type:  enhancement               |      Status:  reviewing
 Priority:  normal                    |   Milestone:  5.3
Component:  Date/Time                 |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+-----------------------------

Comment (by Rarst):

 > This bit is exploiting string vs. int type-casting rounding magic to be
 multiplied by the remainder.

 There is no string involved here, `gmt_offset` is a float value.

 > I think I’d prefer this code to parse the option value as a string
 directly

 I don't follow your suggestion, would you mind expressing it in code? As
 above this isn't a string in first place.

 > unless this is minutes in an hour, which I suppose it probably is, and
 there is no constant for

 It is hour in minutes, yes.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/24730#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform