[wp-trac] [WordPress Trac] #47238: i18n: Avoid using HTML tags in translation strings (wp-admin/plugins.php)
WordPress Trac
noreply at wordpress.org
Sun May 26 13:31:10 UTC 2019
#47238: i18n: Avoid using HTML tags in translation strings (wp-admin/plugins.php)
-------------------------------------------------+-------------------------
Reporter: ramiy | Owner:
| SergeyBiryukov
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 5.3
Component: Plugins | Version:
Severity: normal | Resolution:
Keywords: has-screenshots has-patch 2nd- | Focuses:
opinion | administration
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):
* keywords: has-screenshots has-patch => has-screenshots has-patch 2nd-
opinion
Comment:
The current string is consistent with the other [source:tags/5.2.1/src/wp-
admin/plugins.php?marks=547-551,556-568#L544 plugin action messages]:
* `The selected plugin(s) have been <strong>deleted</strong>.`
* `Plugin <strong>activated</strong>.`
* `Selected plugins <strong>activated</strong>.`
* `Plugin <strong>deactivated</strong>.`
* `Selected plugins <strong>deactivated</strong>.`
However, similar [source:tags/5.2.1/src/wp-
admin/themes.php?marks=203,207,212,220#L195 theme action messages] don't
have the markup:
* `Settings saved and theme activated.`
* `New theme activated.`
* `Theme deleted.`
These are some of the oldest strings in WordPress (`Plugin
<strong>activated</strong>` was introduced in [1071]; `New theme
activated` was introduced in [1655]), and it looks like they have always
been like this.
For consistency, we should probably remove the markup from all these
plugin messages, unless anyone can think of a good reason to keep it.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47238#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list