[wp-trac] [WordPress Trac] #43895: Organize privacy functions into logical files and classes

[WordPress Trac]

#43895: Organize privacy functions into logical files and classes
-------------------------------------------+-----------------------
 Reporter:  iandunn                        |       Owner:  desrosj
     Type:  enhancement                    |      Status:  assigned
 Priority:  normal                         |   Milestone:  5.3
Component:  Privacy                        |     Version:  4.9.6
 Severity:  normal                         |  Resolution:
 Keywords:  early has-patch needs-refresh  |     Focuses:
-------------------------------------------+-----------------------

Comment (by azaozz):

 Replying to [comment:29 desrosj]:
 > Was there a reason that the privacy JavaScript was in `xfn.js`?

 Yes, as with the rest of the code, we couldn't add new files in a dot
 release. `xfn.js` was chosen as a "host" to temporarily hold the privacy
 tools js too.

 > `class-wp-privacy-data-removal-requests-table.php` and `class-wp-
 privacy-data-export-requests-table.php` need to be changed to `class-wp-
 privacy-data-export-requests-list-table.php` and `class-wp-privacy-
 data-(removal erasure?)-requests-list-table.php` respectively. This is for
 the reasons detailed
 [https://core.trac.wordpress.org/ticket/44845#comment:2 here].

 Don't see a problem with renaming them. Yes, the old classes can be added
 to deprecated.php

 > - There will most likely need to be `function_exists()` checks for any
 function reorganized when called. If the function does not exist,
 `include_once` should load `privacy.php`.

 Not seeing any functions that are not loaded. Can re-check the loading
 order just in case.

 > - Some code needs to be added to guarantee that the old privacy tool
 locations (`tools.php?page=export_personal_data` and
 `tools.php?page=remove_personal_data`) are redirected to the new
 locations.

 Right, will need to add that, same as for the privacy-policy-guide.php.

 > Are there any front-end privacy related functions that warrant a `wp-
 includes/privacy.php`?

 Don't think that exists. May be missing something... Or do you mean we way
 need it? :)

 > Also, it will probably be best to split this up into some more
 manageable chunks.

 May be possible but imho will be harder, need to make sure all separate
 "steps" of moving and renaming work by themselves.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43895#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform