[wp-trac] [WordPress Trac] #39110: Better error handling when email cannot be sent during password reset

[WordPress Trac]

#39110: Better error handling when email cannot be sent during password reset
--------------------------------------------------+---------------------
 Reporter:  johnbillion                           |       Owner:  (none)
     Type:  enhancement                           |      Status:  new
 Priority:  normal                                |   Milestone:  5.3
Component:  Mail                                  |     Version:
 Severity:  normal                                |  Resolution:
 Keywords:  has-patch servehappy has-screenshots  |     Focuses:
--------------------------------------------------+---------------------

Comment (by desrosj):

 This is looking good. I have a few thoughts on
 [attachment:"39110.2.patch"], though.

 - At first glance, I would think that `email_disabled` is an error passed
 from a function like `wp_mail()` to indicate e-mails were intentionally
 disabled. Maybe the error code could be `reset_email_failure`, or
 something more specific to the action taking place (unless this same
 message can be triggered somewhere else and should be a bit more global
 feeling). `email_disabled` could also be an error in plugin land
 somewhere.
 - The wording still feels awkward to me. I think that having `Possible
 reason:` sandwiched between too proper sentences is throwing me off.

 I also don't think that the message even needs to mention a server. Maybe
 something less technical could suffice.

 Worked through this with @johnbillion in Slack and we arrived at: `Error:
 The email could not be sent. Your site may not be correctly configured to
 send emails. Get support for resetting your password.` (with the current
 bold/linking).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/39110#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform