[wp-trac] [WordPress Trac] #46154: Woo Commerce Deposits 2.2.8 Plug In by Envato

[WordPress Trac]

#46154: Woo Commerce Deposits 2.2.8 Plug In by Envato
--------------------------+----------------------
 Reporter:  susanfla2     |       Owner:  (none)
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  Plugins       |     Version:
 Severity:  normal        |  Resolution:  invalid
 Keywords:                |     Focuses:
--------------------------+----------------------
Description changed by SergeyBiryukov:

Old description:

> I recently attempted upgrade from 2.2.6 to 2.2.8.  The 2.2.8 plug-in I
> was sold is incomplete in code.  The following are the only fixes found
> in the plug-in php file:
>
> //button css fix for storefront theme
>
>                                 $active_theme = wp_get_theme();
>                                 if( $active_theme->parent() ){
>                                         $theme_name =
> $active_theme->parent()->get( 'Name' );
>
>                                 } else{
>                                         $theme_name = $active_theme->get(
> 'Name' );
>
>                                 }
>                                 if( $theme_name === 'Storefront' ){
>
>                                         ob_start();
>                                         ?>
>

>                     #wc-deposits-options-form label {
>                     margin-left: 0 !important;
>                     }
>                                         <?php
>                                         $css = ob_get_clean();
>                                         wp_add_inline_style( 'toggle-
> switch' , $css );
>

>
> **If you do not have a storefront child theme - the fix is useless**
>

> Other items you will notice between the 2.2.6 and the 2.2.8 features are
> some of the most relevant functions have been ripped out of the code.
> For example, the plug-in developer adds "public $admin_auto_updates" for
> site license verification and strips out the "public $checkout_mode;"
> functionality.
>
> I recommend that the plug-in developers stop copying and pasting code
> from one theme to another and then selling the plug-in as a real product.
> Let's hope I get my money back on that General Public User License I
> bought....

New description:

 I recently attempted upgrade from 2.2.6 to 2.2.8.  The 2.2.8 plug-in I was
 sold is incomplete in code.  The following are the only fixes found in the
 plug-in php file:
 {{{
 //button css fix for storefront theme

                                 $active_theme = wp_get_theme();
                                 if( $active_theme->parent() ){
                                         $theme_name =
 $active_theme->parent()->get( 'Name' );

                                 } else{
                                         $theme_name = $active_theme->get(
 'Name' );

                                 }
                                 if( $theme_name === 'Storefront' ){

                                         ob_start();
                                         ?>


                     #wc-deposits-options-form label {
                     margin-left: 0 !important;
                     }
                                         <?php
                                         $css = ob_get_clean();
                                         wp_add_inline_style( 'toggle-
 switch' , $css );
 }}}


 **If you do not have a storefront child theme - the fix is useless**


 Other items you will notice between the 2.2.6 and the 2.2.8 features are
 some of the most relevant functions have been ripped out of the code.  For
 example, the plug-in developer adds "public $admin_auto_updates" for site
 license verification and strips out the "public $checkout_mode;"
 functionality.

 I recommend that the plug-in developers stop copying and pasting code from
 one theme to another and then selling the plug-in as a real product.
 Let's hope I get my money back on that General Public User License I
 bought....

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46154#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform