[wp-trac] [WordPress Trac] #43895: Organize privacy functions into logical files and classes
WordPress Trac
noreply at wordpress.org
Thu May 23 20:04:16 UTC 2019
#43895: Organize privacy functions into logical files and classes
-----------------------------+-----------------------
Reporter: iandunn | Owner: desrosj
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.3
Component: Privacy | Version: 4.9.6
Severity: normal | Resolution:
Keywords: early has-patch | Focuses:
-----------------------------+-----------------------
Changes (by xkon):
* keywords: needs-patch early => early has-patch
Comment:
[attachment:"43895.diff"] moves code around into the correct files and
makes some necessary adjustments for the new pieces to work.
These include:
- Introduces Export / Erasure pages (erase-personal-data.php, export-
personal-data.php )
- Adds them into the Menu ( please tell me if re-adjusting the priority in
menu.php isn't something that we generally do so I can fix that :) )
- Removes the previous code from user.php
- Introduces privacy.php ( general privacy functions )
- Introduces class-wp-privacy-requests-table.php
- Introduces class-wp-privacy-data-removal-requests-table.php
- Introduces class-wp-privacy-data-export-requests-table.php
- Requires privacy.php into admin.php
- Removes the previous code from xfn.js and introduces privacy.js
- Adds privacy.js to Gruntfile.js
- Adds privacy.js to script-loader.php
- Adds localization for privacyToolsL10n to privacy.js instead of xfn.js
- Enqueues privacy.js instead of xfn.js into Export & Erase data pages.
I hope that I didn't miss anything, do tell me if I have to update any
parts and I'll re-upload a fresh patch asap!
Props for this should go to @birgire and @garrett-eclipse as well please
if committed :).
@azaozz / @desrosj , can you take a look on this when you get some time?
Plenty of things to follow for Exports and other ideas for 5.3 so it'll be
great to have the files finally done :D .
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43895#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list