[wp-trac] [WordPress Trac] #45346: Varnish querystring.sort can break load-styles.php
WordPress Trac
noreply at wordpress.org
Thu May 23 00:18:30 UTC 2019
#45346: Varnish querystring.sort can break load-styles.php
---------------------------+---------------------
Reporter: rabin.io | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.3
Component: Script Loader | Version: 4.9.8
Severity: normal | Resolution:
Keywords: | Focuses:
---------------------------+---------------------
Comment (by azaozz):
In 45346.diff:
- Make the `load` array associative so we can prevent sorting.
- Use `ksort()` in `load-scripts.php` and `load-styles.php`.
@rabinio please test.
> after 6 month of waiting...
Thinking it would have helped if there was a "testable" patch, especially
with some unit tests. Of course you're welcome to add unit tests now if
this patch works well :)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/45346#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list