[wp-trac] [WordPress Trac] #46938: Prevent activation of incompatible plugins without valid readme.txt

[WordPress Trac]

#46938: Prevent activation of incompatible plugins without valid readme.txt
-------------------------------------------------+-------------------------
 Reporter:  afragen                              |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Plugins                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  servehappy has-patch dev-feedback    |     Focuses:
  needs-testing                                  |
-------------------------------------------------+-------------------------

Comment (by Ipstenu):

 > I see this as an either/or choice. The PHP compatibility headers would
 be either in a readme.txt --

 I'm **not** asking about the PHP compat headers at all at this moment.
 I'm asking for clarification about the intent of this ticket, becuase
 based on the name, I think you've crossed your streams. :)

 I think you want to rename this trac ticket, because I get the impression
 you're meaning "Check PHP Compat before activation" and instead you said
 "Don't let plugins with bad readme headers activate." Those aren't at all
 the same thing.

 To be clear:

 * Should we check PHP compatibility before activation? Yes
 * Should we prevent activation if compat is invalid (i.e. you have PHP 5.6
 and the plugin says 7.1)? Yes
 * Should we prevent activation is the PHP compat header is missing? **NO**
 * Should we prevent activation if the readme.txt has mucky headers or is
 missing? **NO**

 > The patch only seeks to allow for the Requires WP and Requires PHP
 headers to be utilized by the compatibility tests. Nothing more.

 Then yeah you absolutely need to rename this ticket, because it's very
 misleading. I recommend "Add Requires WP and Requires PHP headers to
 plugin compatibility tests"

 And remember that lack of those headers, regardless of where they are
 (readme, php, a json file, don't care), means we ''warn'' but still permit
 activation.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46938#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform