[wp-trac] [WordPress Trac] #45346: Varnish querystring.sort can break load-styles.php

[WordPress Trac]

#45346: Varnish querystring.sort can break load-styles.php
---------------------------+---------------------
 Reporter:  rabin.io       |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  5.3
Component:  Script Loader  |     Version:  4.9.8
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:
---------------------------+---------------------
Changes (by azaozz):

 * milestone:  Awaiting Review => 5.3


Comment:

 How about making this an associative array. That should prevent the
 sorting:
 {{{
 /load-styles.php?c=0&dir=rtl&load[chunk_0]=dashicons,admin-
 bar,common,forms,admin-menu,dashboard,list-
 tables,edit,revisions,media,themes,about,nav-menus,wp-
 pointer,widgets&load[chunk_1]=,site-icon,l10n,buttons&ver=4.9.8
 }}}

 Which will produce:
 {{{
 [load] => Array (
       [chunk_0] => dashicons,admin-bar,common,forms,admin-menu,dashboard
 ,list-tables,edit,revisions,media,themes,about,nav-menus,wp-
 pointer,widgets
       [chunk_1] => ,site-icon,l10n,buttons
 )
 }}}

 Can even do a `ksort()` in load-scripts.php for a good measure.

 Patch coming up.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45346#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform