[wp-trac] [WordPress Trac] #47352: Take into account the current admin email address when rate limiting the recovery mode email

[WordPress Trac]

#47352: Take into account the current admin email address when rate limiting the
recovery mode email
----------------------------+-------------------------------------
 Reporter:  johnbillion     |      Owner:  (none)
     Type:  defect (bug)    |     Status:  new
 Priority:  normal          |  Milestone:  Awaiting Review
Component:  Administration  |    Version:  5.2
 Severity:  normal          |   Keywords:  servehappy dev-feedback
  Focuses:                  |
----------------------------+-------------------------------------
 Here's a process which I've seen occur twice in the last few days:

 * A change to a site was deployed and a fatal error gets triggered
 somewhere.
 * The recovery mode email was sent out.
 * The developer checks the current value of the admin email address and
 discovers it belongs to someone who left the company years ago.
 * They change the admin email address to their own email address and re-
 trigger the fatal error, but the recovery mode email doesn't get re-sent
 to the new address because there's a one day rate limit in place.

 This prevents the user from enabling recovery mode for at least a day.

 The option that acts as the "last sent" record for the recovery mode email
 (`recovery_mode_email_last_sent`) should take into account the admin email
 address, for example by hashing it and including it in the option key.

 Aside: Is there a reason an option is used instead of a transient?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47352>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform