[wp-trac] [WordPress Trac] #40878: Adding menus route

WordPress Trac noreply at wordpress.org
Wed May 22 12:36:31 UTC 2019


#40878: Adding menus route
-------------------------------------------------+-------------------------
 Reporter:  dingo_d                              |       Owner:  (none)
     Type:  feature request                      |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  REST API                             |     Version:  4.7
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch dev-feedback needs-unit-   |     Focuses:  rest-api
  tests                                          |
-------------------------------------------------+-------------------------
Changes (by spacedmonkey):

 * keywords:  has-patch dev-feedback => has-patch dev-feedback needs-unit-
     tests


Comment:

 Thanks for everyone's work on this. I spent some time reviewing the patch
 and on the face of it looks good. But I personally believe that there is
 no way to have a meaningful code review via svn patches. I can not do code
 level reviews and discuss this. Any feature of this size, should start as
 a feature plugin.

 To that end, we already have a feature plugin for this at
 [https://github.com/WP-API/wp-api-menus-widgets-endpoints wp-api-menus-
 widgets-endpoints]. @wpscholar if you could take your patch and make it a
 pull request on that repo, we can work on it there. Once we have a solid
 api there, we can create a core patch from that, that should just a copy
 and paste in core.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40878#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list