[wp-trac] [WordPress Trac] #46638: unit test for wp_array_slice_assoc()

WordPress Trac noreply at wordpress.org
Tue May 21 14:21:16 UTC 2019


#46638: unit test for wp_array_slice_assoc()
---------------------------------------------+------------------------
 Reporter:  pbearne                          |       Owner:  desrosj
     Type:  defect (bug)                     |      Status:  reviewing
 Priority:  low                              |   Milestone:  5.3
Component:  General                          |     Version:  3.1
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch has-unit-tests commit  |     Focuses:
---------------------------------------------+------------------------
Changes (by desrosj):

 * keywords:  has-patch has-unit-tests => has-patch has-unit-tests commit
 * version:   => 3.1
 * milestone:  Future Release => 5.3


Comment:

 Thanks for this, @pbearne!

 [attachment:"46638.diff"] corrects the following:

 - Some alignment to adhere to coding standards.
 - Change the data provider method to have a `data_` name.
 - Cleaned up Docblocks to be fully accurate, complete and have proper
 capitalization.
 - Changed the class name to match the
 [https://make.wordpress.org/core/handbook/testing/automated-testing
 /writing-phpunit-tests/#test-classes coding standards].
 - Added a few more test scenarios.
 - Added `@ticket` and `@covers` tags.
 - Fixed typo in file name.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46638#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list