[wp-trac] [WordPress Trac] #47323: Upgrading from WordPress 5.1 to 5.2.1 generates a fatal error

[WordPress Trac]

#47323: Upgrading from WordPress 5.1 to 5.2.1 generates a fatal error
-------------------------------------+---------------------
 Reporter:  imath                    |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  5.2.1
Component:  Upgrade/Install          |     Version:  5.2
 Severity:  blocker                  |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------
Changes (by dd32):

 * keywords:  needs-patch => has-patch needs-testing


Comment:

 Attached patch, untested.

 Needs to be tested for an upgrade from 5.1.1 and 5.0.4 to nightly after
 review commit to trunk.

 How I personally test changes like this, prior to committing or it being
 in a live ZIP file that WordPress can update to:
  - checkout a copy of the version of WordPress you wish to upgrade from
  - Copy the latest trunk/master version of `src/wp-admin/includes/update-
 core.php` over the top of it, overwriting the version it came with.
  - Alter `src/wp-admin/includes/class-core-upgrader.php` to not overwrite
 the above file (For example: https://github.com/WordPress/wordpress-
 develop/commit/e552d2fdd26fc87f5c3d1a49c6a0ff00a0c68e0b )
  - Upgrade, through WP-CLI, wp-admin, or through a cron-task if you're
 testing background updates.

 The result is that WordPress will attempt to upgrade using the locally
 modified version of `update-core.php`, which you can also verify by adding
 an extra `echo` or logging to the file.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47323#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform