[wp-trac] [WordPress Trac] #47169: Use a non-zero exit code when requirements are not met

[WordPress Trac]

#47169: Use a non-zero exit code when requirements are not met
-----------------------------------+-----------------------------
 Reporter:  jrf                    |       Owner:  SergeyBiryukov
     Type:  defect (bug)           |      Status:  reviewing
 Priority:  normal                 |   Milestone:  5.2.1
Component:  Build/Test Tools       |     Version:  3.0
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:19 spacedmonkey]:
 > Called `exit` = `false` means `die` isn't called see
 [https://github.com/WordPress/WordPress/blob/6fe64752be3260f2a47f38e68c2cb77400e5a0c9
 /wp-includes/functions.php#L3240-L3242 this]. This means, that `exit( 1 )`
 is called instead of `die` which is the point here.

 The unit tests suite uses
 [source:tags/5.2/tests/phpunit/includes/functions.php#L205
 _wp_die_handler_exit()] as a handler during installation, which already
 has `exit( 1 )`. However, I guess it wouldn't hurt to add it here
 explicitly as well.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47169#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform