[wp-trac] [WordPress Trac] #47161: Do not break strings to avoid HTML tags in them

[WordPress Trac]

#47161: Do not break strings to avoid HTML tags in them
-----------------------------------+-----------------------------
 Reporter:  dimadin                |       Owner:  SergeyBiryukov
     Type:  defect (bug)           |      Status:  closed
 Priority:  normal                 |   Milestone:  5.2.1
Component:  I18N                   |     Version:
 Severity:  normal                 |  Resolution:  fixed
 Keywords:  has-patch i18n-change  |     Focuses:
-----------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:6 ocean90]:
 > I think we should move the leading space for the screen reader text into
 the argument, see [attachment:"47161.2.diff"].

 I've considered this, but [45331] didn't add any new spaces that weren't
 already there in [45170], so it's not a regression.

 Looking at other strings with the `dashicons-external` icon, they all have
 the space before the screen reader text and the icon:

 * Learn more about updating PHP
 * Read more about what WordPress requires to run.
 * Get help resolving this issue.
 * Read about debugging in WordPress.
 * Read more about why you should use HTTPS

 Same for the strings added earlier in `wp_dashboard_events_news()`,
 `wp_dashboard_php_nag()`, and `wp_direct_php_update_button()`:
 * Meetups
 * WordCamps
 * News
 * Learn more about updating PHP
 * Update PHP

 I've opened #47303 to handle them in a consistent manner, since that's out
 of scope for this ticket.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47161#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform