[wp-trac] [WordPress Trac] #47186: At least one function in /wp-includes/sodium_compat/src/Core32 times out on 32 bit servers

[WordPress Trac]

#47186: At least one function in /wp-includes/sodium_compat/src/Core32 times out on
32 bit servers
-------------------------------------+-------------------------------------
 Reporter:  lovingboth               |       Owner:
                                     |  paragoninitiativeenterprises
     Type:  defect (bug)             |      Status:  reopened
 Priority:  high                     |   Milestone:  5.2.1
Component:  Upgrade/Install          |     Version:  5.2
 Severity:  normal                   |  Resolution:
 Keywords:  needs-testing has-patch  |     Focuses:
  commit                             |
-------------------------------------+-------------------------------------
Changes (by dd32):

 * keywords:  needs-testing has-patch => needs-testing has-patch commit


Comment:

 [attachment:"47186.diff"] is a variant upon [attachment:"47186-support-
 old-wordfence.patch"] and the previous which takes a much more
 conservative approach here. In short, it ignores the `max_execution_time`
 and instead focuses on the runtime speed, if an old library is in use then
 signing is also unavailable.

 [attachment:"47186.update-sodium.diff"] is Sodium_Compat 1.10.0, similar
 to [attachment:"47186-sodium_compat-v1.10.2-fixed.patch"] but updates a
 few ancillary files as well.

 [attachment:"47186.tests.diff"] is an attempt at covering
 `verify_file_signatures()` with a unit test. It also requires that
 `verify_file_signature()` returns in under 10s, covering the original
 cause for concern here, that it could run too long (30-300s as seen in
 comment:32 If nothing else, it fails on environments that aren't properly
 covered.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47186#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform