[wp-trac] [WordPress Trac] #46455: Twenty Nineteen: Remove duplicate function twentynineteen_is_comment_by_post_author from class TwentyNineteen_Walker_Comment
WordPress Trac
noreply at wordpress.org
Tue May 14 20:25:40 UTC 2019
#46455: Twenty Nineteen: Remove duplicate function
twentynineteen_is_comment_by_post_author from class
TwentyNineteen_Walker_Comment
-----------------------------------+-----------------------
Reporter: mukesh27 | Owner: desrosj
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 5.3
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: has-patch fixed-major | Focuses:
-----------------------------------+-----------------------
Comment (by ianbelanger):
I discussed updating the Bundled Themes in minor releases with
@laurelfulford earlier today. She brought up those updates in `5.0.2` as
an example of when it has happened in the past, but she also said that
they were exceptions. The only reason for those fixes in point releases,
was because of the large number of changes to themes prior to `5.0` and
`Gutenberg`.
Quoting @laurelfulford
> Usually, (we only do bundled theme releases in majors) yeah, though
there have been exceptions, like for not-great bugs — we did I think two
theme updates on the two point releases after 5.0, to clean up Gutenberg
issues, for example.
>
> That’s kind of a weird case though — normally we don’t roll out so many
changes to existing themes
I informed her of the milestone changes I made to this and the other
Bundled Theme tickets and she was ok with it.
As a soon-to-be `Bundled Theme Maintainer` I'm personally not against
updating a theme on a point release for site-breaking bugs, but none these
seemed to meet that criteria.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46455#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list