[wp-trac] [WordPress Trac] #47063: Text not vertically centered on site-health.php

[WordPress Trac]

#47063: Text not vertically centered on site-health.php
-------------------------------------------------+-------------------------
 Reporter:  Presskopp                            |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.2.1
Component:  Administration                       |     Version:  5.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch site-      |     Focuses:  ui
  health has-design-feedback                     |
-------------------------------------------------+-------------------------

Comment (by kjellr):

 Great catch again! I agree — I think placing the spinner within the title
 `span` seems to be the best route here. However, I think keeping the
 absolute positioning makes sense in order to ensure that it doesn't add
 some extra height to the button when it's invisible.

 For [attachment:"47063.6.diff"] I did a little reworking in general —
 turns out the mobile view of the Info page was still broken in prior
 patches:

 [[Image(https://cldup.com/-70XLGB3iI-3000x3000.png)]]

 This should be more of a universal fix for all breakpoints. While I was in
 there, I also added a minimum 46px height for these panels to meet the
 usual minimum recommended button size, and to align them with the panel
 height used in Gutenberg.

 **Desktop**

 [[Image(https://cldup.com/wn2c1lY7gF-2000x2000.png)]]

 [[Image(https://cldup.com/7CGfGR29fm-1200x1200.png)]]

 **Mobile**

 [[Image(https://cldup.com/P-GIsLhW4w-3000x3000.png)]]

 [[Image(https://cldup.com/scfukMGLBx-3000x3000.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47063#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform