[wp-trac] [WordPress Trac] #47078: Building may fail to generate *-rtl.css files in wp-includes/css
WordPress Trac
noreply at wordpress.org
Sat May 11 01:54:29 UTC 2019
#47078: Building may fail to generate *-rtl.css files in wp-includes/css
-------------------------------------+---------------------
Reporter: azaozz | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.2.1
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing | Focuses:
-------------------------------------+---------------------
Comment (by azaozz):
> but the wp-includes/css/dist folder is never recreated
Right, it is created but then "cleaned" right after. Happens because `wp-
includes/css/dist` is created by webpack which runs in `build:js`. Then we
get to `build:css` which does `clean:css` and removes `/dist`.
Looking a but "deeper", we don't really need to do any of that `clean:js`,
`clean:css` stuff in /build. All WP files are deleted there anyway.
Perhaps we should make these run only for `grunt --dev` and of course for
`grunt clean --dev`, `grunt clean:css --dev` etc. We should also split the
`clean` tasks from the `build` tasks and do the cleaning before we run
webpack.
For now lets fix this ticket by excluding the `src/wp-includes/css/dist`
directory from processing with `rtlcss`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47078#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list