[wp-trac] [WordPress Trac] #47063: Text not vertically centered on site-health.php

WordPress Trac noreply at wordpress.org
Thu May 9 17:13:29 UTC 2019


#47063: Text not vertically centered on site-health.php
-------------------------------------------------+-------------------------
 Reporter:  Presskopp                            |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.2.1
Component:  Administration                       |     Version:  5.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch site-      |     Focuses:  ui
  health needs-design-feedback                   |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  has-screenshots has-patch site-health needs-refresh => has-
     screenshots has-patch site-health needs-design-feedback


Comment:

 @Presskopp Ah! I see it now, thanks!

 I see why there is a margin now. It is to provide spacing between the text
 and a badge, but badges do not exist on the Info tab. Changing the margin
 from a `margin-bottom` on the title to `margin-top` on the badge helps the
 mobile issue for the Info tab but does compacts a bit.

 Making the text "centered" is also a bit difficult. The badge has a
 padding defined as `0.1rem 0.5rem 0.15rem`. This is to ensure that
 characters like `y` are fully contained in the outline of the badge. The
 same top padding can be applied to the title and it would line up with the
 badge text, but it would still not ''truly'' be vertically centered. It
 also results in the text also being slightly not centered on the Info tab
 (though it's not really noticeable and feels centered).

 [attachment:"47063.3.diff"] makes both of these changes. I'd love to get
 some design feedback on this. Mainly the shortening of the accordions on
 the Info tab. (CC: @melchoyce @karmatosed)

 Another thing to note, the loading GIF does not show correctly on the Info
 tab, but this is a preexisting issue.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47063#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list