[wp-trac] [WordPress Trac] #47119: Can't revoke super admin if email is different case from network admin
WordPress Trac
noreply at wordpress.org
Tue May 7 22:25:24 UTC 2019
#47119: Can't revoke super admin if email is different case from network admin
--------------------------+----------------------------------------
Reporter: trepmal | Owner: SergeyBiryukov
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 5.3
Component: Users | Version: 3.1
Severity: normal | Resolution:
Keywords: has-patch | Focuses: administration, multisite
--------------------------+----------------------------------------
Changes (by SergeyBiryukov):
* status: new => reviewing
* focuses: => administration, multisite
* component: Administration => Users
* milestone: Awaiting Review => 5.3
* owner: (none) => SergeyBiryukov
Old description:
> In multisite, if a Super Admin's email is a case-insensitive match to the
> Network Admin email, the checkbox for revoking super-admin shows, but
> doesn't work.
>
> Reproduction:
> - set Network Admin email to `Admin at example.test`
> - set a Super Admin's email to `admin at example.test`
> - attempt to revoke super admin from same user
>
> This will fail because of the case-insensitive comparison here:
> https://core.trac.wordpress.org/browser/trunk/src/wp-
> includes/capabilities.php#L922
>
> In typical circumstances (when emails do not have a case difference) the
> checkbox doesn't show because of comparison here:
> https://core.trac.wordpress.org/browser/trunk/src/wp-admin/user-
> edit.php#L420
>
> Looks like this has been an issue since about 3.1, maybe older.
>
> relevant commits:
> https://core.trac.wordpress.org/changeset/26115
> https://core.trac.wordpress.org/changeset/16767
New description:
In multisite, if a Super Admin's email is a case-insensitive match to the
Network Admin email, the checkbox for revoking super-admin shows, but
doesn't work.
Reproduction:
- set Network Admin email to `Admin at example.test`
- set a Super Admin's email to `admin at example.test`
- attempt to revoke super admin from same user
This will fail because of the case-insensitive comparison here:
https://core.trac.wordpress.org/browser/trunk/src/wp-
includes/capabilities.php#L922
In typical circumstances (when emails do not have a case difference) the
checkbox doesn't show because of comparison here:
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/user-
edit.php#L420
Looks like this has been an issue since about 3.1, maybe older.
relevant commits: [26115], [16767]
--
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47119#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list