[wp-trac] [WordPress Trac] #47169: Use a non-zero exit code when requirements are not met

WordPress Trac noreply at wordpress.org
Tue May 7 16:52:09 UTC 2019


#47169: Use a non-zero exit code when requirements are not met
-----------------------------------+---------------------
 Reporter:  jrf                    |       Owner:  (none)
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  5.2
Component:  Build/Test Tools       |     Version:  3.0
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+---------------------

Comment (by spacedmonkey):

 I think that the patch
 [https://core.trac.wordpress.org/attachment/ticket/47169/47169.patch
 47169.patch] seems reasonable to me, but I haven't tested it yet.

 I think it is reasonable to get this in 5.2 (maybe 5.2.1) and we can
 change over to use `wp_die` if possible in 5.3+.

 Having a quick look at function, not sure we could use `wp_die` for PHP
 errors, but maybe we could use in for database errors, as other parts of
 core, already do that (wp-db.php already calls `wp_die`).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47169#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list