[wp-trac] [WordPress Trac] #47159: Do not use placeholders for HTML tags in strings
WordPress Trac
noreply at wordpress.org
Mon May 6 21:44:19 UTC 2019
#47159: Do not use placeholders for HTML tags in strings
--------------------------+-----------------------------
Reporter: dimadin | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: I18N | Version: trunk
Severity: normal | Keywords: has-patch
Focuses: |
--------------------------+-----------------------------
[45158] introduced string where placeholders are used instead of HTML
tags. That practice is not used in WordPress core, and it's bad anyway.
Attached patch uses approach used in other strings where it puts link and
additional link attributes behind placeholders.
Note that this text is
[https://github.com/WordPress/gutenberg/blob/b3961d06a3862fb04967b776f2f246dc1f642f0a/packages
/block-library/src/media-text/edit.js#L202 used] in Gutenberg (introduced
in [https://github.com/WordPress/gutenberg/pull/14668 #14668]), however
because of the way links are formed in Gutenberg, same strings can't be
used.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47159>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list