[wp-trac] [WordPress Trac] #47140: Twenty Nineteen: Improve the special pages headings

[WordPress Trac]

#47140: Twenty Nineteen: Improve the special pages headings
---------------------------+-----------------------------
 Reporter:  afercia        |      Owner:  (none)
     Type:  defect (bug)   |     Status:  new
 Priority:  normal         |  Milestone:  Awaiting Review
Component:  Bundled Theme  |    Version:
 Severity:  normal         |   Keywords:  has-screenshots
  Focuses:  accessibility  |
---------------------------+-----------------------------
 Heading in some special pages (search, no content, archives) have rooms
 for improvements both from an accessibility and layout perspective.

 == Search page:

 Current code: https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentynineteen/search.php?rev=44149&marks=21-24#L20

 {{{
 <h1 class="page-title">
         <?php _e( 'Search results for:', 'twentynineteen' ); ?>
 </h1>
 <div class="page-description"><?php echo get_search_query(); ?></div>
 }}}

 This prints out a h1 heading "Search results for:" that doesn't help so
 much users of assistive technologies. The heading should include the
 search term. This way, users would have a proper feedback when navigating
 by headings.

 Worth also noting that the document title becomes:
 `<title>You searched for hello ⋆ WordPress develop</title>`

 The wording could be improved. Users know they searched for {search term}
 because that's what they just did.

 == Search page with no results:
 The heading position is a bit off. See attached screenshot.


 == 404 page (no content):
 The heading position is a bit off. See attached screenshot.

 == Archive pages:
 The vertical spacing between the archives heading and the page content is
 a bit too much, not sure this is intentional. See attached screenshot.
 Note that in this case, the archive description is part of the heading:
 this same pattern should be used for the search term mentioned above.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47140>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform