[wp-trac] [WordPress Trac] #47048: Nav Menus Admin: Missing Deselect All text when toggling Select All
WordPress Trac
noreply at wordpress.org
Sat May 4 20:18:23 UTC 2019
#47048: Nav Menus Admin: Missing Deselect All text when toggling Select All
-------------------------------------+-------------------------------------
Reporter: birgire | Owner: audrasjb
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 5.3
Component: Menus | Version: 3.0
Severity: normal | Resolution:
Keywords: has-screenshots has- | Focuses: ui, accessibility,
patch dev-feedback | administration
-------------------------------------+-------------------------------------
Changes (by birgire):
* focuses: ui, administration => ui, accessibility, administration
Comment:
Thanks for the patch and the gif-animation @audrasjb
The {{{data-toggle}}} attribute approach seems to work nicely.
I noticed another approach in {{{Customizing > Menus}}} for the
Reorder/Done button link:
Reorder:
{{{
<button type="button" class="button-link reorder-toggle" aria-
label="Reorder menu items" aria-describedby="reorder-items-desc-28">
<span class="reorder">Reorder</span>
<span class="reorder-done">Done</span>
</button>
}}}
Done:
{{{
<button type="button" class="button-link reorder-toggle" aria-label="Close
reorder mode" aria-describedby="reorder-items-desc-28">
<span class="reorder">Reorder</span>
<span class="reorder-done">Done</span>
</button>
}}}
where the aria label and the visibility of each span item changes
accordingly via javascript.
Source Ref:
https://core.trac.wordpress.org/browser/tags/5.1.1/src/wp-
includes/customize/class-wp-customize-nav-menu-control.php#L53
https://core.trac.wordpress.org/browser/tags/5.1.1/src/js/_enqueues/wp/customize
/nav-menus.js#L2813
https://core.trac.wordpress.org/browser/tags/5.1.1/src/wp-includes/class-
wp-customize-nav-menus.php#L474
It would be great to get a feedback regarding the accessibility here, so I
add that tag to the ticket.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47048#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list