[wp-trac] [WordPress Trac] #46918: Link Modal Dialog of Editor adds H1-tag to site

[WordPress Trac]

#46918: Link Modal Dialog of Editor adds H1-tag to site
-----------------------------------------+------------------------------
 Reporter:  Asgaros                      |       Owner:  (none)
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  Awaiting Review
Component:  Editor                       |     Version:  4.5
 Severity:  minor                        |  Resolution:
 Keywords:  has-patch reporter-feedback  |     Focuses:  accessibility
-----------------------------------------+------------------------------
Changes (by afercia):

 * keywords:  has-patch => has-patch reporter-feedback


Comment:

 Discussed during today's accessibility bug-scrub. Most of the modals in
 WordPress use a h1, including the Gutenberg ones. That’s a pretty common
 pattern for modals because when the modal opens, its content is supposed
 to be the only perceivable content in a page. Omitting the heading would
 be equivalent to put content in a page without headings.

 Granted, the WordPress modals need many more improvements :) For
 reference, here's an example from the W3C: https://www.w3.org/TR/wai-aria-
 practices-1.1/examples/dialog-modal/dialog.html

 @Asgaros we're not sure we understand the concern here. The heading is
 hidden, search engine crawlers should just ignore it. Do you have data or
 other evidence the ''hidden'' heading is causing problems for SEO?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46918#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform