[wp-trac] [WordPress Trac] #47058: Site Health: does not distinguish between production / staging / development sites

[WordPress Trac]

#47058: Site Health: does not distinguish between production / staging /
development sites
----------------------------+----------------------
 Reporter:  DavidAnderson   |       Owner:  (none)
     Type:  defect (bug)    |      Status:  closed
 Priority:  normal          |   Milestone:
Component:  Administration  |     Version:  trunk
 Severity:  normal          |  Resolution:  wontfix
 Keywords:  site-health     |     Focuses:
----------------------------+----------------------
Description changed by SergeyBiryukov:

Old description:

> In a ticket focussed on a different issue -
> https://core.trac.wordpress.org/ticket/47046 - the problem was raised
> that if `WP_DEBUG` is on, then the "Site Health Check" will raise this as
> a "critical security" issue. The current justification for that is given
> in https://core.trac.wordpress.org/ticket/47046#comment:9 is "You should
> not be running WP_DEBUG on a production site".
>
> However, currently Site Health Check has no concept of whether a site is
> production, staging or development. It just shows the message.
>
> Arguably, if WP_DEBUG is on (and in the ticket above, it was on
> localhost), that's partial evidence that it's not a production site. We
> don't want users to ultimately learn that "Site Health Check is full of
> unhelpful approximations, basically, just ignore half of what it says".
>
> Some possible solutions:
>
> - Remove the check entirely
> - Don't label it as a "Critical Security" issue
> - Introduce a "Production / Development / Staging" switch and then make
> tests behave different depending upon the value

New description:

 In a ticket focussed on a different issue - #47046 - the problem was
 raised that if `WP_DEBUG` is on, then the "Site Health Check" will raise
 this as a "critical security" issue. The current justification for that is
 given in https://core.trac.wordpress.org/ticket/47046#comment:9 is "You
 should not be running WP_DEBUG on a production site".

 However, currently Site Health Check has no concept of whether a site is
 production, staging or development. It just shows the message.

 Arguably, if WP_DEBUG is on (and in the ticket above, it was on
 localhost), that's partial evidence that it's not a production site. We
 don't want users to ultimately learn that "Site Health Check is full of
 unhelpful approximations, basically, just ignore half of what it says".

 Some possible solutions:

 - Remove the check entirely
 - Don't label it as a "Critical Security" issue
 - Introduce a "Production / Development / Staging" switch and then make
 tests behave different depending upon the value

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47058#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform