[wp-trac] [WordPress Trac] #46901: 5.2 About Page
WordPress Trac
noreply at wordpress.org
Thu May 2 15:40:33 UTC 2019
#46901: 5.2 About Page
---------------------------------------+-------------------------
Reporter: desrosj | Owner: karmatosed
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 5.2
Component: Help/About | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots | Focuses:
---------------------------------------+-------------------------
Comment (by afercia):
Noticed two very small things in the responsive view. Not blockers,
they're really minor :) If there's time after RC2, would be nice to try to
improve them though. See the attached screenshot:
- On the left: because of their placement, these two images get displayed
vertically stacked which is a bit weird to see. Really minor, I guess we
can live with that
- On the right: the vertical spacing between sections is a bit
inconsistent, maybe could be improved a bit but I guess we can live with
that as well
Everything else looks good to me. Note related to accessibility: @audrasjb
we forgot to use `aria-current` on the new `<nav>` active items :) I guess
that should be improved in 5.2.1, though it's just about the addition of
an attribute and wouldn't impact anything even if we're in RC2.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46901#comment:57>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list