[wp-trac] [WordPress Trac] #46901: 5.2 About Page

WordPress Trac noreply at wordpress.org
Thu May 2 12:10:21 UTC 2019


#46901: 5.2 About Page
---------------------------------------+-------------------------
 Reporter:  desrosj                    |       Owner:  karmatosed
     Type:  task (blessed)             |      Status:  assigned
 Priority:  normal                     |   Milestone:  5.2
Component:  Help/About                 |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:
---------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 [attachment:"46901-remaining.2.diff"] uses the `s.w.org` domain for images
 and avoids unintentional string change caused by removing curly quotes
 from `“white screen of death,”` in the previous patch.

 Replying to [comment:38 man4toman]:
 > I'm not sure about this, but is it correct?
 > {{{...the so-called “white screen of death,” and...}}}
 >
 > Or it must be:
 > {{{...the so-called “white screen of death”, and...}}}

 [https://www.grammarly.com/blog/quotation-marks/ It's correct in American
 English]. That said, it's inconsistent with a couple of other strings in
 core:

 * If you select "Remember Me", your login will persist for two weeks.
 * Once you hit “Confirm Deletion”, the user will be permanently removed.

 I'm ambivalent on whether the comma placement should be changed here.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46901#comment:49>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list