[wp-trac] [WordPress Trac] #46901: 5.2 About Page
WordPress Trac
noreply at wordpress.org
Wed May 1 21:54:06 UTC 2019
#46901: 5.2 About Page
---------------------------------------+-------------------------
Reporter: desrosj | Owner: karmatosed
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 5.2
Component: Help/About | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots | Focuses:
---------------------------------------+-------------------------
Comment (by ryelle):
[attachment:"46901-layout.diff"] switches the about page to using CSS
grid, but it’s using properties/fallbacks for IE11. The point of this
rewrite was to make the about page’s structural CSS a little more obvious,
and remove the styles for elements that are no longer on this page
(videos, mejs elements, etc – these can be added back if we end up using
them again). Hopefully this will be easier for others to jump into in the
future :)
There are now 4 classes for 1-4 column grids (no more “class ends with
col”!). They all default to 760px wide. Each `has-x-columns` can only have
one row, for compat with IE11. These break at 782px into 2 columns at
most, and at 600px into 1 column.
- `has-1-columns`
- `has-2-columns`
- `has-3-columns`
- `has-4-columns`
You can also add `.is-wider-right` or `.is-wider-left` to the
`has-2-columns` container, to make it one-third/two-thirds. This stays two
column until 480px.
There are also “width” classes. The default for `headline-feature` is 680,
and can be increased to 760 with `is-wide`. `is-fullwidth` can be used to
make it 100% (the container stops at 1200, so it will not be larger than
that).
Alignment classes: we have vertical and horizontal alignment classes.
`aligncenter` will center text, `alignleft` & `alignright` float elements.
`is-vertically-aligned-top`, `is-vertically-aligned-center`, and `is-
vertically-aligned-bottom` assume a flex or grid context, but they’ll
align to the top/center/bottom of the container.
@melchoyce You'll want to check the spacing/alignment of things on the
about page and the other pages in the section (credits, freedoms).
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46901#comment:44>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list