[wp-trac] [WordPress Trac] #44675: Media Trash action verbiage inconsistent and causes confusion

[WordPress Trac]

#44675: Media Trash action verbiage inconsistent and causes confusion
-------------------------------------+---------------------------
 Reporter:  garrett-eclipse          |       Owner:  mikeschroder
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.2
Component:  Media                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:
-------------------------------------+---------------------------
Changes (by garrett-eclipse):

 * keywords:  has-patch => has-patch needs-refresh


Comment:

 Thanks @johnbillion IMHO all of the action labels such as the Bulk Actions
 and the Row Actions should all be 'Move to Trash'. And then 'Trash' should
 be left as is when referring to the View Filter.

 The other instances I found that should be updated are;
 Media Bulk Action -
 https://github.com/WordPress/WordPress/blob/56c162fbc9867f923862f64f1b4570d885f1ff03
 /wp-admin/includes/class-wp-media-list-table.php#L154
 Media Row Action -
 https://github.com/WordPress/WordPress/blob/56c162fbc9867f923862f64f1b4570d885f1ff03
 /wp-admin/includes/class-wp-media-list-table.php#L680
 Comments Row Action* -
 https://github.com/WordPress/WordPress/blob/56c162fbc9867f923862f64f1b4570d885f1ff03
 /wp-admin/includes/class-wp-media-list-table.php#L680
 Comments Handle Row Action -
 https://github.com/WordPress/WordPress/blob/6fe48278eaa539f33bbfe86ccd24b2e7dd6fc83a
 /wp-admin/includes/class-wp-comments-list-table.php#L643
 Posts Row Action -
 https://github.com/WordPress/WordPress/blob/99b929cbbc72171eabc095c2f089316cbc261dbb
 /wp-admin/includes/class-wp-posts-list-table.php#L1366
 Dashboards Comments Row Action -
 https://github.com/WordPress/WordPress/blob/e901bc4c2bbf259258ce3aa3f3d82bcb8f7a6281
 /wp-admin/includes/dashboard.php#L658
 Attachment Submit Meta Box -
 https://github.com/WordPress/WordPress/blob/6fe48278eaa539f33bbfe86ccd24b2e7dd6fc83a
 /wp-admin/includes/meta-boxes.php#L402
 *These in GitHub show they are 'Trash' but looking them up in
 translate.wp.org they're Move to Trash so not sure why.
 **Please refer to any I've overlooked and we'll get this refreshed.

 All the best

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44675#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform