[wp-trac] [WordPress Trac] #46670: Compact throws notice on PHP7.3 at ajax-actions.php

[WordPress Trac]

#46670: Compact throws notice on PHP7.3 at ajax-actions.php
--------------------------+-----------------------------
 Reporter:  pilou69       |       Owner:  SergeyBiryukov
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  5.2
Component:  Taxonomy      |     Version:  5.1
 Severity:  normal        |  Resolution:  fixed
 Keywords:                |     Focuses:  administration
--------------------------+-----------------------------

Comment (by pilou69):

 I should mention that the result of your fix
 https://core.trac.wordpress.org/changeset/45034 is not exactly what PHP7.2
 did.

 You see, in PHP7.2 if the variable for compact didn't exists the resulting
 array won't have the key with the variable name.

 With Your change the 'noparents' key will be always there. I don't know if
 it's a mistake or You were intended to do that.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46670#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform