[wp-trac] [WordPress Trac] #46681: Update mediaelement.js to fix Vimeo auto play issues.
WordPress Trac
noreply at wordpress.org
Wed Mar 27 22:47:16 UTC 2019
#46681: Update mediaelement.js to fix Vimeo auto play issues.
--------------------------------+-----------------------------
Reporter: danieliser | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: External Libraries | Version: 5.1
Severity: normal | Keywords: has-patch
Focuses: |
--------------------------------+-----------------------------
WP core currently includes mediaelementjs v4.2.6.
Due to recent browser changes Vimeo videos no longer will auto play and
often get errors.
A patch was made for this by adding allow="autoplay; fullscreen" here 12
days ago: https://github.com/mediaelement/mediaelement/issues/2618
I propose either:
- Updating this dependency to the latest master branch which is currently
[6
commits](https://github.com/mediaelement/mediaelement/compare/4.2.9...master)
ahead of the latest available release.
- Updating this dependency to the [latest
release](https://github.com/mediaelement/mediaelement/releases) (v4.2.9) &
manually patching the [6
commits](https://github.com/mediaelement/mediaelement/compare/4.2.9...master)
as needed.
- Manually patching the existing version included with WP core to include
this and a few other improvements based on changes to modern browsers over
the past year.
Master is stable from what I can tell, but as its not versioned and I'm
not sure if core would directly accept it without its official release.
This is the specific patch that fixes the Vimeo issue:
https://github.com/mediaelement/mediaelement/commit/e84fa56ced5653408203dd0f0db76a05af497720
Personally since core is on 4.2.6 I see no reason we can't feasibly update
to the current master branch and mark it as 4.2.9 so that in the future
updates will work fine.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46681>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list