[wp-trac] [WordPress Trac] #46349: Is your/this admin email still correct

[WordPress Trac]

#46349: Is your/this admin email still correct
-------------------------------------------------+-------------------------
 Reporter:  andraganescu                         |       Owner:
                                                 |  andraganescu
     Type:  feature request                      |      Status:  assigned
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Users                                |     Version:  5.1
 Severity:  normal                               |  Resolution:
 Keywords:  2nd-opinion needs-design ux-         |     Focuses:
  feedback servehappy                            |  administration
-------------------------------------------------+-------------------------

Comment (by andraganescu):

 In order to display the notification right after login I found two ways:

 1. either change the code and before redirecting stick another form into
 the page like in the [https://core.trac.wordpress.org/raw-
 attachment/ticket/46349/Screenshot%202019-03-27%20at%2021.58.23.png
 Intermission Form Example] example above

 I don't like this approach mainly because it adds a loat of bloat code in
 wp-login.php which is already complex: another function to output another
 form and, plus, we need to pause the redirect flow with more globals.

 2. hook into login_redirect and update the redirect process like this:

 - login
 - login_redirect hook called
  - is the admin email recently verified ? (define an
 ADMIN_EMAIL_REFRESH_TIME in default_constants.php)
   - YES
     - return the normal redirect decided by the system
   - NO
     - return a redirect link to a special place in admin where there is a
 form to update
 - continue to redirect
 - if special admin place:
  - user updates the email?
   - YES
    - save the new admin email
    - set an admin_email_last_check option via the options API to current
 time
    - redirect to the original redirect
   - NO
    - set an admin_email_last_check option via the options API to current
 time - 1/2*ADMIN_EMAIL_REFRESH_TIME
    - redirect to the original redirect

 I am working on option (2) but the UX is weird: the best place to update
 it is on the settings page.

 We could direct the users straight to that long form and via some URI
 param modify the Email Address field to pop out in size and color, and
 also add a question to it.

 Also, we could add a modal overlay with a Form
 [https://core.trac.wordpress.org/raw-
 attachment/ticket/46349/5a85cd561df68_Screenshot1.PNG.412c73d5f803d3ed7ead3bb951810ae9.PNG
 like this] in it, which right now is my favourite idea.

 LMK if you have other thoughts :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46349#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform