[wp-trac] [WordPress Trac] #46657: Show site icon in My Sites admin menu

WordPress Trac noreply at wordpress.org
Tue Mar 26 15:40:34 UTC 2019


#46657: Show site icon in My Sites admin menu
----------------------------+------------------------------
 Reporter:  rmccue          |       Owner:  (none)
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Administration  |     Version:  4.3
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  multisite
----------------------------+------------------------------

Comment (by joemcgill):

 @rmccue I'd suggest using `esc_url()` here.  It's best
 practice—particularly since the output of that function is filterable so
 the value can't be trusted—and would be consistent with other places in
 core where `get_site_icon_url()` is used.

 See examples:

 *
 https://github.com/WordPress/WordPress/blob/b2ae00cd21db0efd07064fdc8474493e08117944
 /wp-includes/embed.php#L1170-L1176
 *
 https://github.com/WordPress/WordPress/blob/eb5c0abc007d17875171aa384929ca916df6751e
 /wp-includes/general-template.php#L888-L890

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46657#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list