[wp-trac] [WordPress Trac] #44133: Should the Data Export indicate when we have no information on the user

[WordPress Trac]

#44133: Should the Data Export indicate when we have no information on the user
-------------------------------------------------+-------------------------
 Reporter:  garrett-eclipse                      |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  5.3
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch needs-     |     Focuses:
  testing 2nd-opinion                            |  administration
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):

 * keywords:  has-screenshots has-patch needs-testing => has-screenshots
     has-patch needs-testing 2nd-opinion


Comment:

 Hi @xkon thanks for the refresh here. This worked nicely.

 I uploaded 44133.10.diff to address some minor items (spelling, grammar
 and missed the ##LINK## phpdoc reference on the second filter) and
 milestone it for 5.3.0. It also updates the unit tests to account for the
 additional parameters. Which makes me wonder if we should make the extra
 two params optional with the `= false` for backward compatibility as I
 added a check if $request is false already. Thoughts?

 I'm a little torn with the introduction of a second filter for almost the
 same email, especially since the boolean differentiating the two is
 supplied as an argument. I understand the email content differs by the
 single new line so there's that to take into account as well.

 As to the indication to the user @birgire mentioned I assume he's speaking
 of the in-table-row notice produced when erasing the content. See #44135
 for the screens and existing work around this. I added a related there to
 tie back and indicate that flow change would also benefit here.

 All the best,
 Cheers

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44133#comment:52>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform